Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FitResult.cost returns half the expected value of the objective function #80

Closed
luisfabib opened this issue Feb 23, 2021 · 0 comments
Closed
Labels
bug Something isn't working
Milestone

Comments

@luisfabib
Copy link
Collaborator

The FitResult.cost attribute of the fit result objects should be returning the value of the objective function:

cost = sum(residual**2)

which right now is taken directly from the output of the different least-squares solvers in Scipy. However, these return half of the value. For example the least_squares function returns (as per the documentation):

cost = 1/2*sum(residual**2)

This must be corrected and made consistent throughout DeerLab.

@luisfabib luisfabib added the bug Something isn't working label Feb 23, 2021
@luisfabib luisfabib added this to the 0.13.0 milestone Mar 7, 2021
luisfabib added a commit that referenced this issue Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant