snlls: Fix violation of boundaries due to float-point round-off errors
#188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisfabib
added
bug
luisfabib
changed the title
Jacobian: Fix violation of boundaries to float-point round-off errors Jacobian: Fix violation of boundaries due to float-point round-off errors
stestoll
requested changes
Jun 28, 2021
|
After digging a bit more, the float-point error appears in one of the variables returned by the |
luisfabib
changed the title
Jacobian: Fix violation of boundaries due to float-point round-off errors snlls: Fix violation of boundaries due to float-point round-off errors
stestoll
approved these changes
Jul 2, 2021
luisfabib
added a commit
that referenced
this pull request
Jul 2, 2021
…ors (#188) * Jacobian: add rounding to avoid float-point round-off errors * Jacobian: use exception handling to avoid rounding in all cases * snlls: shield linear LSQ results against float-point errors
Merged
luisfabib
added a commit
that referenced
this pull request
Jul 2, 2021
* Enable code analysis by GitHub's CodeQL (#186) * examples: fix rendering of RST code-blocks in notebooks (#179) (#184) * Fix call to pipwin executable during PyPI installation (#187) * `snlls`: Fix violation of boundaries due to float-point round-off errors (#188) * docs: fix automated example plots in the models reference (#190) * VERSION: bump to v0.13.2 * Implement automated PyPI and Anaconda build and publish workflow (#185) * Update CHANGELOG for v0.13.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #177