Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct behavior of masking during fitting #394

Merged
merged 3 commits into from
Oct 28, 2022
Merged

Correct behavior of masking during fitting #394

merged 3 commits into from
Oct 28, 2022

Conversation

luisfabib
Copy link
Collaborator

Features

  • Add several tests for the fit and snlls functions to check the masking behavior.
  • Fix the behavior of goodness-of-fit assessment and noise level estimation in the presence of masks.
  • Add several missing outputs of fit and snlls to their docstrings.

Closes #383

@luisfabib luisfabib added the bugfix Patches something that isn't working label Oct 28, 2022
@luisfabib luisfabib added this to the v1.0 milestone Oct 28, 2022
@luisfabib luisfabib requested a review from stestoll October 28, 2022 07:32
@luisfabib luisfabib merged commit 1875f24 into main Oct 28, 2022
@luisfabib luisfabib deleted the fix/masking branch October 28, 2022 09:24
@luisfabib luisfabib mentioned this pull request Dec 9, 2022
luisfabib added a commit that referenced this pull request Dec 9, 2022
* freeze sphinx-gallery version to 0.9.0 to fix current docs build (#371)

* Correct behavior of masking during fitting (#394)

* Deprecate distribution through Anaconda (#400)

- Remove all CI/CD files associated to the build and release process
- Adjust the installation instructions
- Adjust the CI/CD workflow to just run through PyPI

* examples: fix background plot error in 4-pulse DEER examples

* bootstrap_analysis: fix error when analyzing scalar variables (#402)

* fit: Expose `cores` option of bootstrap_analysis (#387)

* examples: minor fix

* update changelog

* bump version

* changelog: minor edit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Patches something that isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data masks are not accounted for at different stages involving the data
2 participants