Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change time definition in RIDME #436

Merged
merged 6 commits into from
Aug 9, 2023
Merged

Change time definition in RIDME #436

merged 6 commits into from
Aug 9, 2023

Conversation

stestoll
Copy link
Collaborator

@stestoll stestoll commented Aug 7, 2023 •
edited
Loading

4-pulse DEER: t=0 is right after second observer pulse.
RIDME: t=0 is tau1 after second pulse.
This is inconsistent. Probably the least disruptive fix is to update the RIDME t definition to match the 4-pulse DEER definition.

This fixes #433.

@stestoll stestoll added the bugfix Patches something that isn't working label Aug 7, 2023
@stestoll stestoll requested a review from HKaras August 7, 2023 20:24
@stestoll stestoll self-assigned this Aug 7, 2023
@stestoll stestoll changed the title fix time definitions in RIDME (fixes #433) Change time definition in RIDME (fixes #433) Aug 9, 2023
@stestoll stestoll changed the title Change time definition in RIDME (fixes #433) Change time definition in RIDME Aug 9, 2023
@stestoll stestoll removed the bugfix Patches something that isn't working label Aug 9, 2023
@stestoll stestoll marked this pull request as ready for review August 9, 2023 07:11
@stestoll stestoll marked this pull request as draft August 9, 2023 08:05
@stestoll stestoll marked this pull request as ready for review August 9, 2023 16:25
HKaras
HKaras approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@HKaras HKaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. Only question is if we really need both the svg and png versions or we could move to only having the single svg.

@stestoll stestoll merged commit f092956 into main Aug 9, 2023
@stestoll stestoll deleted the fixes/ridmetimes branch August 9, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HKaras HKaras HKaras approved these changes

Assignees

@stestoll stestoll

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refocusing times in ex_ridme
2 participants
@stestoll @HKaras