Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of UncertQuant object under disabled uncertainty analysis #56

Merged
merged 4 commits into from
Nov 2, 2020

Conversation

luisfabib
Copy link
Collaborator

When the uncertainty quantification analysis is disabled in the fit functions (uqanalysis=False), the corresponding output is returned as an empty list. This can lead to errors such as the one described in #54.

These changes will now prompt instead an exception to inform that the data is not available:

ValueError: The requested attribute is not available. Uncertainty quantification has not 
been calculated during the fit by using the `uqanalysis=False` keyword.

@luisfabib luisfabib added this to the 0.13.0 milestone Nov 2, 2020
@luisfabib luisfabib requested a review from stestoll November 2, 2020 15:59
@luisfabib luisfabib linked an issue Nov 2, 2020 that may be closed by this pull request
@stestoll stestoll merged commit d3da9f6 into main Nov 2, 2020
@stestoll stestoll deleted the feature/uncertquant_void branch November 2, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle UncertQuant objects for case uqanalysis=False
2 participants