Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplification of the inital and boundary values interface for fitsignal #71

Merged
merged 5 commits into from
Jan 5, 2021

Conversation

luisfabib
Copy link
Collaborator

Resolves #40

As discussed in #40 this PR introduces a simplified interface for the definition of the initial values and boundary constraints of the different model parameters subsets. This new interface align well with the principles in PEP20.

Previous keywords:
par0, lb, ub
New keywords:
par0_dd, par0_bg, par0_ex, lb_dd, lb_bg, lb_ex, ub_dd, ub_bg, ub_ex

@luisfabib luisfabib added the enhancement New feature or request label Jan 2, 2021
@luisfabib luisfabib added this to the 0.13.0 milestone Jan 2, 2021
@luisfabib luisfabib requested a review from stestoll January 2, 2021 15:14
deerlab/fitsignal.py Outdated Show resolved Hide resolved
deerlab/fitsignal.py Outdated Show resolved Hide resolved
deerlab/fitsignal.py Outdated Show resolved Hide resolved
deerlab/fitsignal.py Outdated Show resolved Hide resolved
examples/plot_fitting_5pdeer.py Show resolved Hide resolved
examples/plot_fitting_mixed_model.py Outdated Show resolved Hide resolved
@stestoll stestoll merged commit 17d4f7e into main Jan 5, 2021
@stestoll stestoll deleted the feature/fitsignal_bounds_interface branch January 5, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify parameter boundaries interface for fisignal
2 participants