Adjust parameters built-in start values for user-defined bounds in fitsignal #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ounds - added control statement to adapt start bounds if not user-defined - done some refactoring of the code - added new tests
stestoll
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72
In
fitsignalnow the parameter boundaries are validatef in two ways depending on the definition of the start valuespar0:par0: if the user specifies lower/upper boundaries for a parameter but not its start values, then if the built-in start values would conflict with the new bounds, these are adapted (by setting them to the middle of the bound region).par0: if the user specifies boundaries and start values, then the usual check is performed and if a conflict is found, then an error is prompted to request the user to correct the input.