Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed bootstrapping into fitsignal #88

Merged
merged 6 commits into from
Mar 15, 2021
Merged

Conversation

luisfabib
Copy link
Collaborator

Internalize the bootstrapping of all fitsignal quantities to ease the use of bootstrapping for standard workflows. The user can change between covariance and bootstrapped uncertainty quantification via the a new option:

fit = dl.fitsignal(V,t,r,uq='covariance') # covariance-based uncertainty quantification
fit = dl.fitsignal(V,t,r,uq='bootstrap') # bootstrapped uncertainty quantification

By default, the bootstrap will be done with 1000 samples to ensure quality. Still, the number of samples can be specified as follows:

fit = dl.fitsignal(V,t,r,uq=['bootstrap',100]) # bootstrapped uncertainty quantification with 100 samples

Closes #75

Changelog:

  • Major refactoring of fitsignal code
  • Embed call of bootan into fitsignal
  • Add new tests to check bootstrapped quantities
  • Speedup fitsignal tests

@luisfabib luisfabib added the enhancement New feature or request label Mar 12, 2021
@luisfabib luisfabib added this to the 0.13.0 milestone Mar 12, 2021
@luisfabib luisfabib requested a review from stestoll March 12, 2021 11:01
@luisfabib luisfabib merged commit 5bd5adf into main Mar 15, 2021
@stestoll stestoll deleted the feature/fitsignal_bootstrapping branch March 19, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internalize bootstrapping for fitsignal quantities
2 participants