Improved implementation of ptr-to-member-fcn for surrogate gradient #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, do we have tests that check that selecting different surrogate gradient functions works? |
|
@heplesser Thanks a lot for this elegant approach. A test selecting different surrogate gradients sounds like a nice idea. I will work on that right now and them we can test everything before merging |
|
This new code passes the tests introduced in 65f6efa |
|
This looks good to me, thanks a lot! |
akorgor
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @JesusEV and @akorgor,
This PR cleans up the syntax of the pointer-to-member code by using a typedef (I found https://isocpp.org/wiki/faq/pointers-to-members helpful). Also, the map needs to be created only once as a static variable, not for each call to
select_...().