Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple low pass filters of eligibility trace and firing rate #34

Merged

Conversation

akorgor
Copy link
Collaborator

@akorgor akorgor commented Sep 5, 2024

This PR undoes commit 2783bd6 and aims to fix learning performance issues for the case of kappa=0.

@akorgor akorgor requested a review from JesusEV September 5, 2024 07:05
@JesusEV
Copy link
Owner

JesusEV commented Sep 5, 2024

@akorgor Agnes, there is one technical aspect that is missing. The ideas shown in the lines, eprop_archiving_node.cpp:213 and, for example, eprop_iaf.cpp:427 are based on the factorization described in the attached document.
firing_rate_reg.pdf

@JesusEV
Copy link
Owner

JesusEV commented Sep 5, 2024

@akorgor The sentence "According to Bellec et al. (2020), equation (2) suggests" would be better read as "According to equation (2) from Bellec et al. (2020)".

@JesusEV
Copy link
Owner

JesusEV commented Sep 5, 2024

@akorgor I can address the missing steps by creating a new branch from this one. Once I'm done, you can merge it back into this branch. Let me know if that works for you.

@akorgor
Copy link
Collaborator Author

akorgor commented Sep 5, 2024

@akorgor I can address the missing steps by creating a new branch from this one. Once I'm done, you can merge it back into this branch. Let me know if that works for you.

Ah true, very good point. Please go ahead with the fix!

JesusEV and others added 3 commits September 9, 2024 09:19
Co-authored-by: Agnes Korcsak-Gorzo <40828647+akorgor@users.noreply.github.com>
Co-authored-by: Agnes Korcsak-Gorzo <40828647+akorgor@users.noreply.github.com>

Co-authored-by: Agnes Korcsak-Gorzo <40828647+akorgor@users.noreply.github.com>
@akorgor akorgor merged commit afbebc4 into JesusEV:eprop_bio_feature Sep 9, 2024
21 of 22 checks passed
@akorgor akorgor deleted the fix_decouple-low-pass-filters branch September 9, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants