fix: EXPOSED-621 IllegalStateException on accessing autoincrement column after insert using Entity #2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joc-a
force-pushed
the
joc/exposed-621
branch
from
970dbee
to
be851b6
Compare
bog-walk
approved these changes
Nov 1, 2024
exposed-tests/src/test/kotlin/org/jetbrains/exposed/sql/tests/shared/ddl/SequencesTests.kt
Outdated
Show resolved
Hide resolved
…umn after insert using Entity The issue was that the `hashCode()` function was using `sequence` which invokes `autoincSeq` if `_sequence` is null, which then invokes `currentDialect`, and if this is not within a transaction, it will throw an error. The fix is to use `_sequence` instead of `sequence` when generating a hashcode.
joc-a
force-pushed
the
joc/exposed-621
branch
from
be851b6
to
e717ff4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue was that the
hashCode()function was usingsequencewhich invokesautoincSeqif_sequenceis null, which then invokescurrentDialect, and if this is not within a transaction, it will throw an error. This was introduced here.The fix is to use
_sequenceinstead ofsequencewhen generating a hashcode.Type of Change
Please mark the relevant options with an "X":
Updates/remove existing public API methods:
Affected databases:
Checklist
Related Issues