JBR-8216 Implement setAccessibilityValue method for NavigableTextAccessibility #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OnePatchGuy
requested changes
Feb 9, 2025
src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/NavigableTextAccessibility.m
Outdated
Show resolved
Hide resolved
…ssibility * This method allows for third-party tools to modify text component contents through the accessibility API on macOS; * The setAccessibilityValue method is implemented similarly to NavigableTextAccessibility.setAccessibilitySelectedText. On the Java side, it calls AccessibleEditableText.setTextContents according to the comment in JavaTextAccessibility.accessibilitySetValueAttribute; * The isAccessibilitySelectorAllowed method is implemented similarly to JavaTextAccessibility.accessibilityIsValueAttributeSettable: it checks if the text component implements AccessibleEditableText, is enabled, and additionally checks if the editable property is true, because some components could be enabled but not editable, and we shouldn't allow setting the value in this case.
dmitrii-drobotov
force-pushed
the
ddrobotov/JBR-8216
branch
from
7fe70e7 to
c36b448
Compare
OnePatchGuy
approved these changes
Feb 13, 2025
|
The patch has been delivered to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accessibilityIsValueAttributeSettableandaccessibilitySetValueAttribute, but in the current implementation we need to implementsetAccessibilityValueandisAccessibilitySelectorAllowed;setAccessibilityValuemethod is implemented similarly toNavigableTextAccessibility.setAccessibilitySelectedText. On the Java side, it callsAccessibleEditableText.setTextContentsaccording to the comment inJavaTextAccessibility.accessibilitySetValueAttribute;isAccessibilitySelectorAllowedmethod is implemented similarly toJavaTextAccessibility.accessibilityIsValueAttributeSettable: it checks if the text component implementsAccessibleEditableText, is enabled, and additionally checks if the editable property is true, because some components could be enabled but not editable, and we shouldn't allow setting the value in this case.Demo of this feature in Accessibility Inspector tool:
Screen.Recording.2025-02-07.at.11.13.29.mov
It's possible to edit value only for editable text components. Before this change, the button to edit the value was not even showing.