Support software keyboard inset in Dialog
#1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dima-avdeev-jb
approved these changes
Feb 8, 2024
igordmn
approved these changes
Feb 14, 2024
MatkovIvan
force-pushed
the
ivan.matkov/dialog-ime-inset
branch
from
8e0746c to
16f408d
Compare
|
Hi, I am still having this issue with compose version 1.6.0-rc03. Anyone else? I am using BasicAlertDialog component as shown below.
|
|
@pcorreia89 it won't be included in 1.6.0 because it introduces a new public API after a feature freeze for this release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Dialogcentering calculation.DialogProperties.useSoftwareKeyboardInsetoption to disable this behavior.Dialog)Known issues
platformLayers = trueon iOSTesting
Test: run mpp, DialogWithTextField page
useSoftwareKeyboardInset = trueuseSoftwareKeyboardInset = falseIssues Fixed
Fixes JetBrains/compose-multiplatform#4210