Fix NaN font metrics by initializing typeface for TextStyle
#1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise fontMetrics that we are using below might be unreliable
This comment was marked as resolved.
This comment was marked as resolved.
MatkovIvan
approved these changes
Feb 11, 2024
|
@MatkovIvan could you also merge it when it's done? I have no write access to this repo |
MatkovIvan
changed the title
MatkovIvan
changed the title
NaN font metrics by initializing typeface for TextStyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise fontMetrics that we are using below might be unreliable
see: https://github.com/JetBrains/skia/blob/6843251caf4eb4134ab91e98c8063df3cab792b1/modules/skparagraph/src/TextStyle.cpp#L172
if
fTypefaceisn't initialized we will get some default metrics, it may be e.g. all zeroes in some configurations, and it may lead to Inf and NaN valuesProposed Changes
Testing
Test: Describe how you tested your changes. Note that this line (with
Test:) is required, your PR will not build without it!Issues Fixed
Fixes: [Optional] The bug on https://issuetracker.google.com being fixed
Google CLA
You need to sign the Google Contributor’s License Agreement at https://cla.developers.google.com/.
This is needed since we synchronise most of the code with Google’s AOSP repository. Signing this agreement allows us to synchronise code from your Pull Requests as well.