Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop window layer fixes #1181

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Desktop window layer fixes #1181

merged 2 commits into from
Mar 12, 2024

Conversation

MatkovIvan
Copy link
Member

Proposed Changes

  • Draw scrim on the main view when it's required by separate window layer
  • Fix updating position of window layer - tracking the position of the real window in addition to the windowContainer
  • Fix propagation of density/layoutDirection
  • Use focus-lost callback as click outside trigger

Testing

Test: Set compose.layers.type = WINDOW and try to use Popup/Dialog
TODO: screenshot auto-testing

@MatkovIvan MatkovIvan requested a review from igordmn March 11, 2024 11:32
@igordmn

This comment was marked as resolved.

Sign in to view
@MatkovIvan MatkovIvan mentioned this pull request Mar 12, 2024
Merged
@MatkovIvan MatkovIvan merged commit d6cd2d0 into jb-main Mar 12, 2024
6 checks passed
@MatkovIvan MatkovIvan deleted the ivan.matkov/fix-window-layer branch March 12, 2024 16:15
MatkovIvan added a commit that referenced this pull request Mar 12, 2024
@MatkovIvan
Apply hack for window transparency to WINDOW layer too (#1185)
ab9df91 
## Proposed Changes

- Apply hack for window transparency that we already had for main window
to `WINDOW` layer too

## Testing

Test: Try mouse input at `WINDOW` layers on Windows

## Issues Fixed

Fixes
#1181 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igordmn igordmn igordmn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatkovIvan @igordmn