Allow drawing outside of platform layers #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-sasha
reviewed
Mar 13, 2024
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/AwtEventFilter.desktop.kt
Outdated
Show resolved
Hide resolved
...ose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/SwingComposeSceneLayer.desktop.kt
Outdated
Show resolved
Hide resolved
...e/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/DesktopComposeSceneLayer.desktop.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/DesktopComposeSceneLayer.desktop.kt # compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/SwingComposeSceneLayer.desktop.kt # compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/WindowComposeSceneLayer.desktop.kt
m-sasha
reviewed
Mar 14, 2024
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/AwtEventFilter.desktop.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/AwtEventFilter.desktop.kt
Outdated
Show resolved
Hide resolved
...ose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/SwingComposeSceneLayer.desktop.kt
Outdated
Show resolved
Hide resolved
m-sasha
reviewed
Mar 14, 2024
...ose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/SwingComposeSceneLayer.desktop.kt
Outdated
Show resolved
Hide resolved
m-sasha
reviewed
Mar 14, 2024
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/RenderNodeLayer.skiko.kt
Outdated
Show resolved
Hide resolved
m-sasha
approved these changes
Mar 14, 2024
igordmn
requested changes
Mar 14, 2024
# Conflicts: # compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/window/ComposeContainer.uikit.kt
igordmn
approved these changes
Mar 22, 2024
MatkovIvan
added a commit
that referenced
this pull request
Apr 18, 2024
MatkovIvan
added a commit
that referenced
this pull request
Jun 5, 2024
Correct version of reverted change #1285 Fixes JetBrains/compose-multiplatform#4924 ## Testing Manually, see #1190 This should be tested by QA ## Release Notes ### Fixes - Multiple Platforms - Fixed `Popup` jerking during ripple effect animation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
BBHFactoryto record bounds inPictureskiko#889 (skiko0.7.98)Testing
Test: Try to use new platform layers with shadows
Issues Fixed
Fixes: JetBrains/compose-multiplatform#4460