Fixed crash in Cupertino Textfield when a last symbol is a carriage return symbol #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imate line when last line consists of carriage return symbol only
…imate line + fixed logic by tap on the right edge of the penultimate end when last line consists of any whitespace symbol only
mazunin-v-jb
force-pushed
the
v.mazunin/cupertino-textfield-crash-fix
branch
from
90ddf68 to
7d9ca66
Compare
elijah-semyonov
approved these changes
Apr 2, 2024
ASalavei
reviewed
Apr 2, 2024
| @@ -123,12 +123,12 @@ internal fun findNextNonWhitespaceSymbolsSubsequenceStartOffset( | |||
|
|
|||
| nextOffset = charIterator.next() | |||
|
|
|||
| while (nextOffset != BreakIterator.DONE) { | |||
| while (nextOffset < currentText.length) { // charIterator.next() works one more time than needed, better use this | |||
There was a problem hiding this comment.
Can we use if (nextOffset != BreakIterator.DONE) on the line 124 to make code a bit more elegant and get rid of the comment in current line?
igordmn
pushed a commit
that referenced
this pull request
Apr 4, 2024
…eturn symbol (#1229) ## Proposed Changes - Fixed crash in cupertino textfield after tapping at the end of penultimate line when last line consists of carriage return symbol only - Fixed check for tap on the right edge of penultimate line when last line consists of carriage return symbol only ## Testing Test: Open the app, go Components -> Textfields -> AlmostFullScreen, scroll to the bottom, tap at the end of the 99 line. ## Issues Fixed Fixes: https://youtrack.jetbrains.com/issue/COMPOSE-1207/iOS-crash-in-TextField Should also fix JetBrains/compose-multiplatform#4531 ## Google CLA You need to sign the Google Contributor’s License Agreement at https://cla.developers.google.com/. This is needed since we synchronise most of the code with Google’s AOSP repository. Signing this agreement allows us to synchronise code from your Pull Requests as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Testing
Test: Open the app, go Components -> Textfields -> AlmostFullScreen, scroll to the bottom, tap at the end of the 99 line.
Issues Fixed
Fixes: https://youtrack.jetbrains.com/issue/COMPOSE-1207/iOS-crash-in-TextField
Should also fix JetBrains/compose-multiplatform#4531
Google CLA
You need to sign the Google Contributor’s License Agreement at https://cla.developers.google.com/.
This is needed since we synchronise most of the code with Google’s AOSP repository. Signing this agreement allows us to synchronise code from your Pull Requests as well.