Opt-in a11y argument for iOS interop #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASalavei
approved these changes
May 8, 2024
MatkovIvan
reviewed
May 8, 2024
| @@ -112,6 +142,7 @@ fun <T : UIView> UIKitView( | |||
| onRelease: (T) -> Unit = STUB_CALLBACK_WITH_RECEIVER, | |||
| onResize: (view: T, rect: CValue<CGRect>) -> Unit = DefaultViewResize, | |||
| interactive: Boolean = true, | |||
| accessibilityEnabled: Boolean = true, | |||
There was a problem hiding this comment.
@igordmn Do you know if it's a compatible change for K/N?
There was a problem hiding this comment.
I don't know, but we don't guarantee compatibility until iOS Release.
Also, we need to enable binary validator for native before that.
MatkovIvan
added a commit
that referenced
this pull request
May 22, 2024
Fix regression after #1350 Before | After ---|---  | 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's non-trivial to figure out if the UIKit content has any accessibility element in its subtree in a general case. In the same time interop UIViews can taint the tree of SemanticsModifierNode merging its children and redirecting all accessibility input to interop UIView, missing all other data. This lead to unexpected situations, where Compose controls were inaccessible because they contained a native UIKit element inside.
Add
accesibilityEnabledargument toUIKitView/UIKitViewControllerAPIsDon't set
interopViewsemantics property unlessaccesibilityEnabledis true.Document the interaction thoroughly.
Testing
Release Notes
Features - iOS
accessibilityEnabled: Boolean = trueargument toUIKitViewandUIKitViewController.Note
Additive API changes consequences are unclear for Kotlin/Native source sets. Should we do overloads with extra parameters as well? cc @igordmn