Revert "Revert "Don't show code completion for non-existenst API in commonMain that fails on Android with NoSuchMethodException""
#1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…commonMa…" This reverts commit 83d0871.
igordmn
deleted the
revert-1351-revert-1328-igor.demin/fix-skiko-api-in-common
branch
igordmn
added a commit
that referenced
this pull request
Sep 16, 2024
Fixes https://youtrack.jetbrains.com/issue/CMP-5864/Compose-UI-test-error-on-android-No-static-method-forceEnableAppTracing Regression after #1367 During redirection we added dependencies from "androidMain.dependencies" to the Android target, which contain a lot of prerelease versions. Also, we usually don't update `androidMain` during merges. Instead of `androidMain` we should use `commonMain`. `androidMain` dependencies are added transitively from `androidx` redirection. ## Testing 1. ``` ./gradlew :mpp:publishComposeJbToMavenLocal ``` `~/.m2/repository/org/jetbrains/compose/ui/ui-test/0.0.0-SNAPSHOT/ui-test-0.0.0-SNAPSHOT.module`, search `monitor`. It doesn't exist anymore 2. Retest #1328 ## Release Notes ### Fixes - Multiplatform - _(prerelease fix)_ Fix "Compose UI test error on android: No static method forceEnableAppTracing" - _(prerelease fix)_ Fix "Android target depends on prerelease versions"
igordmn
added a commit
that referenced
this pull request
Sep 16, 2024
Fixes https://youtrack.jetbrains.com/issue/CMP-5864/Compose-UI-test-error-on-android-No-static-method-forceEnableAppTracing Regression after #1367 During redirection we added dependencies from "androidMain.dependencies" to the Android target, which contain a lot of prerelease versions. Also, we usually don't update `androidMain` during merges. Instead of `androidMain` we should use `commonMain`. `androidMain` dependencies are added transitively from `androidx` redirection. ## Testing 1. ``` ./gradlew :mpp:publishComposeJbToMavenLocal ``` `~/.m2/repository/org/jetbrains/compose/ui/ui-test/0.0.0-SNAPSHOT/ui-test-0.0.0-SNAPSHOT.module`, search `monitor`. It doesn't exist anymore 2. Retest #1328 ## Release Notes ### Fixes - Multiplatform - _(prerelease fix)_ Fix "Compose UI test error on android: No static method forceEnableAppTracing" - _(prerelease fix)_ Fix "Android target depends on prerelease versions"
igordmn
added a commit
that referenced
this pull request
Sep 16, 2024
Fixes https://youtrack.jetbrains.com/issue/CMP-5864/Compose-UI-test-error-on-android-No-static-method-forceEnableAppTracing Regression after #1367 During redirection we added dependencies from "androidMain.dependencies" to the Android target, which contain a lot of prerelease versions. Also, we usually don't update `androidMain` during merges. Instead of `androidMain` we should use `commonMain`. `androidMain` dependencies are added transitively from `androidx` redirection. ## Testing 1. ``` ./gradlew :mpp:publishComposeJbToMavenLocal ``` `~/.m2/repository/org/jetbrains/compose/ui/ui-test/0.0.0-SNAPSHOT/ui-test-0.0.0-SNAPSHOT.module`, search `monitor`. It doesn't exist anymore 2. Retest #1328 ## Release Notes ### Fixes - Multiplatform - _(prerelease fix)_ Fix "Compose UI test error on android: No static method forceEnableAppTracing" - _(prerelease fix)_ Fix "Android target depends on prerelease versions"
igordmn
added a commit
that referenced
this pull request
Sep 16, 2024
Fixes https://youtrack.jetbrains.com/issue/CMP-5864/Compose-UI-test-error-on-android-No-static-method-forceEnableAppTracing Regression after #1367 During redirection we added dependencies from "androidMain.dependencies" to the Android target, which contain a lot of prerelease versions. Also, we usually don't update `androidMain` during merges. Instead of `androidMain` we should use `commonMain`. `androidMain` dependencies are added transitively from `androidx` redirection. ## Testing 1. ``` ./gradlew :mpp:publishComposeJbToMavenLocal ``` `~/.m2/repository/org/jetbrains/compose/ui/ui-test/0.0.0-SNAPSHOT/ui-test-0.0.0-SNAPSHOT.module`, search `monitor`. It doesn't exist anymore 2. Retest #1328 ## Release Notes ### Fixes - Multiplatform - _(prerelease fix)_ Fix "Compose UI test error on android: No static method forceEnableAppTracing" - _(prerelease fix)_ Fix "Android target depends on prerelease versions"
igordmn
added a commit
that referenced
this pull request
Sep 16, 2024
Fixes https://youtrack.jetbrains.com/issue/CMP-5864/Compose-UI-test-error-on-android-No-static-method-forceEnableAppTracing Regression after #1367 During redirection we added dependencies from `androidMain.dependencies` to the Android target, which contains a lot of prerelease versions. Also, we usually don't update `androidMain` during merges. Instead of `androidMain` we should use `commonMain`. Pure `androidMain` dependencies are added transitively from `androidx` redirection. ## Testing 1. ``` ./gradlew :mpp:publishComposeJbToMavenLocal ``` `~/.m2/repository/org/jetbrains/compose/ui/ui-test/0.0.0-SNAPSHOT/ui-test-0.0.0-SNAPSHOT.module`, search `monitor`. It doesn't exist anymore 2. Retest #1328 This should be tested by QA. ## Release Notes ### Fixes - Multiplatform - _(prerelease fix)_ Fix "Compose UI test error on android: No static method forceEnableAppTracing" - _(prerelease fix)_ Fix "Android target depends on prerelease versions"
igordmn
added a commit
that referenced
this pull request
Sep 16, 2024
Fixes https://youtrack.jetbrains.com/issue/CMP-5864/Compose-UI-test-error-on-android-No-static-method-forceEnableAppTracing Regression after #1367 During redirection we added dependencies from `androidMain.dependencies` to the Android target, which contains a lot of prerelease versions. Also, we usually don't update `androidMain` during merges. Instead of `androidMain` we should use `commonMain`. Pure `androidMain` dependencies are added transitively from `androidx` redirection. ## Testing 1. ``` ./gradlew :mpp:publishComposeJbToMavenLocal ``` `~/.m2/repository/org/jetbrains/compose/ui/ui-test/0.0.0-SNAPSHOT/ui-test-0.0.0-SNAPSHOT.module`, search `monitor`. It doesn't exist anymore 2. Retest #1328 This should be tested by QA. ## Release Notes ### Fixes - Multiplatform - _(prerelease fix)_ Fix "Compose UI test error on android: No static method forceEnableAppTracing" - _(prerelease fix)_ Fix "Android target depends on prerelease versions"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1351