Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix text brush animation #1395

Merged
merged 5 commits into from
Jun 10, 2024
Merged

Fix text brush animation #1395

merged 5 commits into from
Jun 10, 2024

Conversation

MatkovIvan
Copy link
Member

@MatkovIvan MatkovIvan commented Jun 7, 2024 •
edited
Loading

  • Adopt androidx@1631196 change
  • Use paragraph.updateForegroundPaint instead of full rebuild where possible

Fixes JetBrains/compose-multiplatform#4903

Testing

Added Android TextBrushDemo in mpp demo

Screenshot 2024-06-07 at 19 21 39

This should be tested by QA

Release Notes

Fixes - Multiple Platforms

  • Fix text brush animation and optimized updating some visual text properties (applying time is reduced up to 40%)

@MatkovIvan MatkovIvan requested a review from igordmn June 7, 2024 17:22
@MatkovIvan MatkovIvan mentioned this pull request Jun 7, 2024
Closed
@MatkovIvan MatkovIvan merged commit 76db76b into jb-main Jun 10, 2024
8 checks passed
@MatkovIvan MatkovIvan deleted the ivan.matkov/fix-brush-animation branch June 10, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igordmn igordmn igordmn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ShaderBrush#createShader state reads do not invalidate Text composable
2 participants
@MatkovIvan @igordmn