Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actual openURL method in demo #1573

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

ASalavei
Copy link
Collaborator

@ASalavei ASalavei commented Sep 18, 2024

Fixes the following error on iOS 18:

The caller of UIApplication.openURL(_:) needs to migrate to the non-deprecated UIApplication.open(_:options:completionHandler:). Force returning false (NO).

Related bug: https://youtrack.jetbrains.com/issue/CMP-6699

@elijah-semyonov
Copy link

It's a demo bug

@elijah-semyonov
Copy link

@ASalavei
Copy link
Collaborator Author

ASalavei commented Sep 18, 2024

The actual reported one is here: https://github.com/JetBrains/skiko/blob/1ca83c19144127faedbff1c65967d8381c252114/skiko/src/uikitMain/kotlin/org/jetbrains/skiko/Actuals.uikit.kt#L6

I guess we just need to move it out of Skiko?

@elijah-semyonov , this MR - just a related fix.
And you're right, the bug came from skiko, the fix will be there soon.

@ASalavei
Copy link
Collaborator Author

ASalavei commented Sep 18, 2024

@elijah-semyonov , FYI: JetBrains/skiko#990

@ASalavei ASalavei merged commit 27fa6f7 into jb-main Sep 18, 2024
6 checks passed
@ASalavei ASalavei deleted the andrei.salavei/use-actual-openurl branch September 18, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants