Deprecate defaultUIKitMain() in order to remove it #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
requested changes
Sep 23, 2024
| fun defaultUIKitMain(executableName: String, rootViewController: UIViewController) | ||
| = defaultUIKitMain(executableName) { rootViewController } | ||
|
|
||
| fun defaultUIKitMain(executableName: String, makeRootViewController: () -> UIViewController) { |
There was a problem hiding this comment.
Is it a final look of this API? Name? Package? Parameters?
Also:
- No docs for public API
There was a problem hiding this comment.
The method marked as deprecated.
|
I think it's an accidental public API during transition to Beta. AFAIK, nobody but us uses it. |
ASalavei
changed the title
|
@elijah-semyonov , thank for the info. I think we should deprecate it and remove from the public API. |
MatkovIvan
reviewed
Sep 27, 2024
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/main/DefaultIOSMain.uikit.kt
Outdated
Show resolved
Hide resolved
MatkovIvan
reviewed
Sep 27, 2024
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/main/DefaultIOSMain.uikit.kt
Outdated
Show resolved
Hide resolved
MatkovIvan
approved these changes
Sep 27, 2024
ASalavei
deleted the
andrei.salavei/postpone-vc-creation-in-defaultUIKitMain
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the app crashes on a swipe back gesture, if the root controller is a
UINavigationController.The UIApplication should be initialized before the view controller is being created.
defaultUIKitMainshould be moved to the demo app and should not be part of the public API.Release Notes
Fixes - iOS