-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation common UI tests #1596
Conversation
…e NavBackStackEntryState.
…ProviderTest to common.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It's a huge improvement in nav library port!
navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NavDestination.kt
Outdated
Show resolved
Hide resolved
@@ -124,7 +124,7 @@ public actual open class NavDestination actual constructor( | |||
} | |||
|
|||
@RestrictTo(RestrictTo.Scope.LIBRARY_GROUP) | |||
public actual open fun matchDeepLink(route: String): DeepLinkMatch? { | |||
public actual fun matchDeepLink(route: String): DeepLinkMatch? { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this place is a mess, but you're removing an ability to override it from public. Is it expected? It's restricted to LIBRARY_GROUP
, so probably it's ok 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. I synchronized the API with the android part. there was a mistake. The change fixes the problem with a nested navigation
Line 355 in 778cf00
public actual fun matchDeepLink(route: String): DeepLinkMatch? { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should fix https://youtrack.jetbrains.com/issue/CMP-6689
I will check
Move a bunch of Navigation UI tests to common.
Fixes CMP-6689 iOS Navigation Crash Nested Graphs popBackStack
Release Notes
Fixes - Navigation
No destination with ID 0 is on the NavController's back stack
crash on iOS.