Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation common UI tests #1596

Merged
merged 13 commits into from
Sep 26, 2024
Merged

Navigation common UI tests #1596

merged 13 commits into from
Sep 26, 2024

Conversation

terrakok
Copy link
Member

@terrakok terrakok commented Sep 25, 2024

Move a bunch of Navigation UI tests to common.

Fixes CMP-6689 iOS Navigation Crash Nested Graphs popBackStack

Release Notes

Fixes - Navigation

  • Fixed No destination with ID 0 is on the NavController's back stack crash on iOS.

@terrakok terrakok requested a review from MatkovIvan September 25, 2024 16:11
Copy link
Member

@MatkovIvan MatkovIvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's a huge improvement in nav library port!

@@ -124,7 +124,7 @@ public actual open class NavDestination actual constructor(
}

@RestrictTo(RestrictTo.Scope.LIBRARY_GROUP)
public actual open fun matchDeepLink(route: String): DeepLinkMatch? {
public actual fun matchDeepLink(route: String): DeepLinkMatch? {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this place is a mess, but you're removing an ability to override it from public. Is it expected? It's restricted to LIBRARY_GROUP, so probably it's ok 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. I synchronized the API with the android part. there was a mistake. The change fixes the problem with a nested navigation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terrakok terrakok requested a review from MatkovIvan September 26, 2024 09:52
@terrakok terrakok merged commit 43d0247 into jb-main Sep 26, 2024
5 of 6 checks passed
@terrakok terrakok deleted the k.tskh/navigation-common-tests branch September 26, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants