Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make formatWithSkeleton internal #1609

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

ASalavei
Copy link
Collaborator

@ASalavei ASalavei commented Oct 1, 2024

Fixes: https://youtrack.jetbrains.com/issue/CMP-6777/Make-formatWithSkeleton-internal

Release Notes

Fixes - iOS

  • Fixed visibility of androidx.compose.material3.internal.formatWithSkeleton that was accidently marked as public

@ASalavei ASalavei requested review from MatkovIvan and igordmn October 1, 2024 12:43
@MatkovIvan
Copy link
Member

Please fix Release notes before merge, it's quite misleading now especially for "Highlights". It wasn't in public in common yet.

I'd say it's a technical change that should go without mentioning in release notes at all. If you really want to mention it there, please write a proper explanation

@ASalavei
Copy link
Collaborator Author

Please fix Release notes before merge, it's quite misleading now especially for "Highlights". It wasn't in public in common yet.

I'd say it's a technical change that should go without mentioning in release notes at all. If you really want to mention it there, please write a proper explanation

@MatkovIvan, as this is an API change, it seems like it should go with the release note. I will update the wording, but it seems "Highlights" fits best here. See other available section titles:

  • Known Issues
  • Breaking Changes
  • Features
  • Fixes

@ASalavei ASalavei requested a review from MatkovIvan October 14, 2024 12:07
@MatkovIvan
Copy link
Member

### Fixes - iOS
- Fixed visibility of `androidx.compose.material3.internal.formatWithSkeleton` that was accidently marked as public

@ASalavei ASalavei merged commit 2a766f0 into jb-main Oct 15, 2024
5 of 6 checks passed
@ASalavei ASalavei deleted the andrei.salavei/Make-formatWithSkeleton-internal branch October 15, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants