Make common Uri class for the deeplinks support #1610

terrakok · 2024-10-01T13:01:47Z

The PR commonizes android Uri to be able to use it in a common code for the deeplink navigation.

On user's projects side it can be utilized like:

//common code
fun String.toDeepLinkRequest() = NavDeepLinkRequest.Builder.fromUri(
    UriUtils.parse(this)
).build()

navController.navigate(
    "app://compose.io/nested/super/777?param=lucky".toDeepLinkRequest()
)

Testing

More than 300 android integration tests in the navigation-common module related to deep links were migrated to the multiplatform.

...n/navigation-common/src/androidMain/kotlin/androidx/navigation/NavDeepLinkRequest.android.kt

core/core-uri/src/jbMain/kotlin/androidx/core/uri/Uri.jb.kt

navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NavDeepLink.kt

MatkovIvan

🔥

Make common Uri class for the deeplinks support

a9d1c4a

terrakok requested a review from MatkovIvan October 1, 2024 13:01

MatkovIvan reviewed Oct 1, 2024

View reviewed changes

...n/navigation-common/src/androidMain/kotlin/androidx/navigation/NavDeepLinkRequest.android.kt Outdated Show resolved Hide resolved

Extract a common Uri to the new utility library

fe0f35d

MatkovIvan reviewed Oct 2, 2024

View reviewed changes

terrakok added 2 commits October 2, 2024 12:30

Add a default empty type map to the setUriPattern method

3f0cb18

Avoid nullability in UriUtils

9cf31bc

terrakok requested a review from MatkovIvan October 2, 2024 10:41

Dump API

0c200ad

MatkovIvan approved these changes Oct 2, 2024

View reviewed changes

terrakok merged commit ef10317 into jb-main Oct 2, 2024
5 of 6 checks passed

terrakok deleted the k.tskh/common-deeplinks branch October 2, 2024 12:44