Do not use states for layer invalidation without new layers #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjBooms
approved these changes
Oct 17, 2024
igordmn
approved these changes
Nov 1, 2024
igordmn
pushed a commit
that referenced
this pull request
Nov 1, 2024
Fixes https://youtrack.jetbrains.com/issue/CMP-6877/Do-not-use-states-for-layer-invalidation-without-new-layers Disable state tracking for old internal layers if there is no need to do so (no active new layers). It's considered as a temporary solution for 1.7.x It's probably better to wait @igordmn before merging ## Testing Run [LazyGrid benchmark](https://github.com/JetBrains/compose-multiplatform/blob/master/benchmarks/ios/jvm-vs-kotlin-native/src/commonMain/kotlin/benchmarks/lazygrid/LazyGrid.kt)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://youtrack.jetbrains.com/issue/CMP-6877/Do-not-use-states-for-layer-invalidation-without-new-layers
Disable state tracking for old internal layers if there is no need to do so (no active new layers).
It's considered as a temporary solution for 1.7.x
It's probably better to wait @igordmn before merging
Testing
Run LazyGrid benchmark