Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getRouteWithArgs when an argument is not registered as route typed argument #1634

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Fix getRouteWithArgs when an argument is not registered as route typed argument #1634

merged 2 commits into from
Oct 15, 2024

Conversation

terrakok
Copy link
Member

Fix untyped navigation route arguments.

Before a route was empty if an app uses:

route("screen?id={id}") {
  it.arguments.getString("id")
}

@terrakok terrakok requested a review from MatkovIvan October 14, 2024 13:02
@terrakok terrakok merged commit a91c276 into jb-main Oct 15, 2024
2 checks passed
@terrakok terrakok deleted the k.tskh/nav-route-pars branch October 15, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatkovIvan MatkovIvan MatkovIvan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terrakok @MatkovIvan