Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Accessibility demos from Android Demo app #1724

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Add Accessibility demos from Android Demo app #1724

merged 1 commit into from
Dec 11, 2024

Conversation

ASalavei
Copy link
Collaborator

@ASalavei ASalavei commented Dec 11, 2024 •
edited
Loading

Add accessibility demos from Android App to common demos

MatkovIvan
MatkovIvan reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@MatkovIvan MatkovIvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a library change, please remove release notes

MatkovIvan
MatkovIvan approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@MatkovIvan MatkovIvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not blocking this, but I don't like the direction to where mpp demo goes. I'd prefer commonizing AOSP integration demo instead of copying parts from it to mpp

@ASalavei
Copy link
Collaborator Author

but I don't like the direction to where mpp demo goes. I'd prefer commonizing AOSP integration demo instead of copying parts from it to mpp

@MatkovIvan , agree, let's keep it in mind.

@ASalavei ASalavei merged commit 2d8c5f4 into jb-main Dec 11, 2024
7 checks passed
@ASalavei ASalavei deleted the andrei.salavei/android-accessibility-samples branch December 11, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazunin-v-jb mazunin-v-jb mazunin-v-jb approved these changes

@MatkovIvan MatkovIvan MatkovIvan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ASalavei @MatkovIvan @mazunin-v-jb