Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lifecycle 2.9.0-alpha08 #1743

Open
wants to merge 8 commits into
base: integration
Choose a base branch
from

Conversation

terrakok
Copy link
Member

Apply lifecycle 2.9.0-alpha08 from AOSP (commit 46295bc0b75a16f452e8e0090e8de41073d4dbb6)

Release Notes

N/A

@terrakok
Copy link
Member Author

terrakok commented Dec 17, 2024

Builds are fail because lifecycle-runtime library was published with Kotlin 2.1.0 for native targets with no KotlinTarget 1.9 compatibility. And we cannot build lifecycle-runtime-compose which depends on that.

.../lifecycle-runtime-linuxX64Main-2.9.0-alpha08.klib. 
Incompatible abi version. The current default is '1.8.0', found '1.201.0'. The library produced by 2.1.0 compiler

Copy link
Member

@MatkovIvan MatkovIvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that build fails not only because kotlin version:

e: lifecycle/lifecycle-viewmodel-savedstate/src/commonMain/kotlin/androidx/lifecycle/SavedStateHandleSupport.kt:64:18 Unresolved reference: SavedState
e: lifecycle/lifecycle-viewmodel-savedstate/src/commonMain/kotlin/androidx/lifecycle/SavedStateHandleSupport.kt:102:23 Not enough information to infer type variable T
e: lifecycle/lifecycle-viewmodel-savedstate/src/commonMain/kotlin/androidx/lifecycle/SavedStateHandleSupport.kt:152:32 Unresolved reference: SavedState

lifecycle/lifecycle-common/build.gradle Show resolved Hide resolved
@terrakok
Copy link
Member Author

ab

I see that build fails not only because kotlin version:

e: lifecycle/lifecycle-viewmodel-savedstate/src/commonMain/kotlin/androidx/lifecycle/SavedStateHandleSupport.kt:64:18 Unresolved reference: SavedState
e: lifecycle/lifecycle-viewmodel-savedstate/src/commonMain/kotlin/androidx/lifecycle/SavedStateHandleSupport.kt:102:23 Not enough information to infer type variable T
e: lifecycle/lifecycle-viewmodel-savedstate/src/commonMain/kotlin/androidx/lifecycle/SavedStateHandleSupport.kt:152:32 Unresolved reference: SavedState

because it requires Savedstate update, yes. I will rebase it after

@terrakok terrakok force-pushed the k.tskh/lifecycle-2.9.0-alpha08 branch from b7c9a34 to 82888b4 Compare December 20, 2024 15:03
@terrakok
Copy link
Member Author

Well, the MR is ready and waits a solution to the klib abi version problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants