Support defaultOverscrollFactory() on iOS #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
Dec 20, 2024
...oundation/src/uikitMain/kotlin/androidx/compose/foundation/gestures/UikitScrollable.uikit.kt
Show resolved
Hide resolved
MatkovIvan
reviewed
Dec 20, 2024
| @@ -313,6 +314,8 @@ internal fun BasicTextField( | |||
|
|
|||
| DisposableEffect(textFieldSelectionState) { onDispose { textFieldSelectionState.dispose() } } | |||
|
|
|||
| val overscrollEffect = rememberTextFieldOverscrollEffect() | |||
There was a problem hiding this comment.
Is it a regression after merging? Why should it be in the same PR? Why isn't it AOSP first edit?
There was a problem hiding this comment.
Is it a regression after merging?
Yes
Why should it be in the same PR?
It fixes bugs within the overscroll functionality. Basically, keeps the code that was added by us and removed then after AOSP merge. If you feel that it should be in another one, please let me know the reasons.
Why isn't it AOSP first edit?
- The feature has not beed upstreamed yet.
- Too long feedback loop.
| @@ -148,8 +151,8 @@ class CupertinoOverscrollEffect( | |||
|
|
|||
| private fun NestedScrollSource.toCupertinoScrollSource(): CupertinoScrollSource? = | |||
| when (this) { | |||
| NestedScrollSource.Drag -> CupertinoScrollSource.DRAG | |||
| NestedScrollSource.Fling -> CupertinoScrollSource.FLING | |||
There was a problem hiding this comment.
Why was it renamed? I might be slightly out of context here, could you please explain?
There was a problem hiding this comment.
Sure, the old values where deprecated and no longer supported.
MatkovIvan
approved these changes
Dec 20, 2024
...e/foundation/foundation/src/uikitMain/kotlin/androidx/compose/foundation/Overscroll.uikit.kt
Outdated
Show resolved
Hide resolved
mazunin-v-jb
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add implementation of OverscrollFactory to support new Overscroll API.
Fix overscroll in CoreTextField and BasicTextField.
Upstreaming issue added: https://youtrack.jetbrains.com/issue/CMP-7307/Upstreaming.feature.foundation.text.rememberTextFieldOverscrollEffect
Fixes https://youtrack.jetbrains.com/issue/CMP-7143/Support-OverscrollFactory-and-LocalOverscrollFactory
Release Notes
Fixes - iOS
optOutOfCupertinoOverscroll()removed.