Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interop initial z-order placement on Windows #1774

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

MatkovIvan
Copy link
Member

Fix counting of non-interop components for initial interop placement on Windows. It was a regression after #1340: it subtracts root.componentCount before change and interopComponents.size after a change that results in an incorrect value during initial placement. Any further invalidations like window resizing corrected the problem.

Fixes https://youtrack.jetbrains.com/issue/CMP-7375

Testing

Manually - screenshot testing in this case requires DX rendering, so our CI won't handle that.

Release Notes

Fixes - Desktop

  • Fix interop initial z-order placement on Windows with compose.interop.blending flag (1.7.0 regression)

@MatkovIvan MatkovIvan requested review from m-sasha and igordmn January 13, 2025 13:29
@MatkovIvan MatkovIvan merged commit 74515df into jb-main Jan 14, 2025
7 checks passed
@MatkovIvan MatkovIvan deleted the ivan.matkov/fix-interop-placement branch January 14, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants