Fix SkiaLayer transform #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/SkiaLayer.skiko.kt
Show resolved
Hide resolved
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/SkiaLayer.skiko.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/skikoTest/kotlin/androidx/compose/ui/platform/SkiaLayerTest.kt
Show resolved
Hide resolved
…m/SkiaLayer.skiko.kt Co-authored-by: dima.avdeev <99798741+dima-avdeev-jb@users.noreply.github.com>
dima-avdeev-jb
approved these changes
Mar 6, 2023
igordmn
reviewed
Mar 6, 2023
compose/ui/ui/src/skikoTest/kotlin/androidx/compose/ui/platform/SkiaLayerTest.kt
Show resolved
Hide resolved
igordmn
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Proper calculation of transformation matrix in
SkiaLayer. Now it matches android implementation.Testing
Test: Compare result of applying
graphicsLayerparameters (rotation*andcameraDistance) between android and desktop.Please note that 2 tests are failing because golden images need to be updated. TODO
Issues Fixed
Fixes JetBrains/compose-multiplatform#12
Fixes JetBrains/compose-multiplatform#1129