Animate scroll initiated by mouse wheel input #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
requested changes
Mar 18, 2023
...undation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt
Outdated
Show resolved
Hide resolved
...undation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt
Outdated
Show resolved
Hide resolved
...undation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt
Outdated
Show resolved
Hide resolved
...undation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt
Outdated
Show resolved
Hide resolved
...undation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt
Show resolved
Hide resolved
...undation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt
Outdated
Show resolved
Hide resolved
...undation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt
Outdated
Show resolved
Hide resolved
...undation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt
Show resolved
Hide resolved
...undation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt
Outdated
Show resolved
Hide resolved
...undation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt
Show resolved
Hide resolved
igordmn
reviewed
Mar 21, 2023
...undation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt
Show resolved
Hide resolved
...undation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt
Show resolved
Hide resolved
...undation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt
Show resolved
Hide resolved
...undation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt
Outdated
Show resolved
Hide resolved
...undation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt
Show resolved
Hide resolved
igordmn
reviewed
Mar 22, 2023
...undation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt
Show resolved
Hide resolved
...ndation/src/desktopTest/kotlin/androidx/compose/foundation/gestures/DesktopScrollableTest.kt
Outdated
Show resolved
Hide resolved
...undation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt
Outdated
Show resolved
Hide resolved
igordmn
approved these changes
Mar 23, 2023
igordmn
pushed a commit
that referenced
this pull request
Nov 15, 2023
…l input (#438) * Set scroll progress state on mouse events * Animate mouse wheel scroll * Refactor changes * Add helper inline functions * Batch offsets * Filter zero values and apply raw delta only without animation * Use scrollBy inside animation, fix parameter usage in lambda * Fix tests * Add TODOs and comments * Fix more tests * Cleanup mouse hover test helper class * Add test for scroll during animation * Address feedback (part 1) * Make smooth scrolling configurable * Do not animate scroll on events from trackpads * Fix internal type for tests * Make animation scrolling speed density dependant * Fix conditionally applying scroll modifier * Fix cancel animation condition * Cache smooth scrolling flag * Adjust scrolling animation threshold * Add isScrollInProgress TODO * Add test for isSmoothScrollingEnabled flag * Reset flag in finally * Use strict comparison to detect consuming event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
isScrollInProgress: It's true during animation now ( LazyListState.isScrollInProgress is always false on desktop compose-multiplatform#1423 )Testing
Test: Scroll some scrollable view via mouse wheel; Observe smooth animated position changes.
Issues Fixed
Fixes JetBrains/compose-multiplatform#1955