Add minLines to the BasicTextiField.destkop #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same as here: https://android-review.googlesource.com/c/platform/frameworks/support/+/2237754 We don't need to support binary compatibility for this function, as it is experimental
m-sasha
approved these changes
Mar 31, 2023
| @@ -133,7 +134,8 @@ fun BasicTextField( | |||
| keyboardOptions: KeyboardOptions = KeyboardOptions.Default, | |||
| keyboardActions: KeyboardActions = KeyboardActions.Default, | |||
| singleLine: Boolean = false, | |||
| maxLines: Int = Int.MAX_VALUE, | |||
| maxLines: Int = if (singleLine) 1 else Int.MAX_VALUE, | |||
There was a problem hiding this comment.
Can just be maxLines: Int = Int.MAX_VALUE because if singleLine it's ignored below anyway.
There was a problem hiding this comment.
Better to keep the same code as in the original text field, to simplify future copy-pastes
| @@ -281,7 +285,8 @@ fun BasicTextField( | |||
| keyboardOptions: KeyboardOptions = KeyboardOptions.Default, | |||
| keyboardActions: KeyboardActions = KeyboardActions.Default, | |||
| singleLine: Boolean = false, | |||
| maxLines: Int = Int.MAX_VALUE, | |||
| maxLines: Int = if (singleLine) 1 else Int.MAX_VALUE, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as here: https://android-review.googlesource.com/c/platform/frameworks/support/+/2237754
We don't need to support binary compatibility for this function, as it is experimental.