Fix focus in Cupertino textfield #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mazunin-v-jb
commented
Dec 18, 2023
| @@ -98,6 +98,12 @@ private fun getTapHandlerModifier( | |||
| detectRepeatingTapGestures( | |||
| onTap = { touchPointOffset -> | |||
| if (currentState.hasFocus) { | |||
| // To show keyboard if it was hidden. Even in selection mode (like native) | |||
| tapTextFieldToFocus( | |||
There was a problem hiding this comment.
@dima-avdeev-jb
It seems like I messed up with the naming of that method in Common code in my previous request dedicated to that feature. Under the hood, this method is responsible to focus if textfield was unfocused and to show the keyboard if textfield was focused. Should I make another request for fixing that, or I can fix it here?
|
I will wait fix with naming and approve after that |
dima-avdeev-jb
approved these changes
Dec 23, 2023
mazunin-v-jb
deleted the
v.mazunin/dev/fix-focus-in-cupertino-textfield
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
added explicit showing keyboard method in focused textfield (like it is in android)
Testing
Test: open app, go to Application layouts, toggle "Insets" switch, then try to click on 'show keyboard' textfield and 'hide keyboard' button repetitively.
Issues Fixed
https://youtrack.jetbrains.com/issue/COMPOSE-667/fix-Regression-with-TextField-and-Keyboard
Google CLA
You need to sign the Google Contributor’s License Agreement at https://cla.developers.google.com/.
This is needed since we synchronise most of the code with Google’s AOSP repository. Signing this agreement allows us to synchronise code from your Pull Requests as well.