Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use buildDir instead when unzipping WixTools #2804

Closed
jasonsparc opened this issue Feb 27, 2023 · 2 comments · Fixed by #2838
Closed

Use buildDir instead when unzipping WixTools #2804

jasonsparc opened this issue Feb 27, 2023 · 2 comments · Fixed by #2838
Assignees

Comments

@jasonsparc
Copy link

Recently, I noticed that a directory wix311 is being created whenever I run the task runDistributable, and the culprit appears to be, https://github.com/JetBrains/compose-jb/blob/f6c36c392696a2d4229f1cd5db02248ba9b8ff62/gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/desktop/application/internal/wixToolset.kt#L40

I believe it should've been root.buildDir, rather than root.projectDir

Looking into the pull request related to it,
https://github.com/JetBrains/compose-jb/pull/2639/files#diff-c17db91fb640e81e12c9c330652e7388a45e41d222dc27014b8e0d7c6fbd76f3

…you'll see that buildDir was indeed used before that pull request.

This is currently a hassle in version control and I see no reason why it shouldn't reside in the build directory instead.

@jasonsparc jasonsparc added bug Something isn't working submitted labels Feb 27, 2023
@igordmn
Copy link
Collaborator

igordmn commented Feb 28, 2023

Thanks!

Reproduced with Compose 1.3.0 in desktop-template on Windows. After we run ./gradlew runDistributable, we see this folder:

image

@okushnikov
Copy link
Collaborator

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants