We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildDir
Recently, I noticed that a directory wix311 is being created whenever I run the task runDistributable, and the culprit appears to be, https://github.com/JetBrains/compose-jb/blob/f6c36c392696a2d4229f1cd5db02248ba9b8ff62/gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/desktop/application/internal/wixToolset.kt#L40
wix311
runDistributable
I believe it should've been root.buildDir, rather than root.projectDir
root.buildDir
root.projectDir
Looking into the pull request related to it, https://github.com/JetBrains/compose-jb/pull/2639/files#diff-c17db91fb640e81e12c9c330652e7388a45e41d222dc27014b8e0d7c6fbd76f3
…you'll see that buildDir was indeed used before that pull request.
This is currently a hassle in version control and I see no reason why it shouldn't reside in the build directory instead.
build
The text was updated successfully, but these errors were encountered:
Thanks!
Reproduced with Compose 1.3.0 in desktop-template on Windows. After we run ./gradlew runDistributable, we see this folder:
desktop-template
./gradlew runDistributable
Sorry, something went wrong.
Unzip wix to build directory
7d5462f
Resolves #2804
Unzip wix to build directory (#2838)
3483fee
Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.
AlexeyTsvetkov
Successfully merging a pull request may close this issue.
Recently, I noticed that a directory
wix311
is being created whenever I run the taskrunDistributable
, and the culprit appears to be, https://github.com/JetBrains/compose-jb/blob/f6c36c392696a2d4229f1cd5db02248ba9b8ff62/gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/desktop/application/internal/wixToolset.kt#L40I believe it should've been
root.buildDir
, rather thanroot.projectDir
Looking into the pull request related to it,
https://github.com/JetBrains/compose-jb/pull/2639/files#diff-c17db91fb640e81e12c9c330652e7388a45e41d222dc27014b8e0d7c6fbd76f3
…you'll see that
buildDir
was indeed used before that pull request.This is currently a hassle in version control and I see no reason why it shouldn't reside in the
build
directory instead.The text was updated successfully, but these errors were encountered: