Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move compose/golden/compose/ui/ui-desktop into androidx/golden/compose/ui/ui-desktop #2819

Closed
igordmn opened this issue Mar 3, 2023 · 1 comment · Fixed by JetBrains/compose-multiplatform-core#423
Closed

Move compose/golden/compose/ui/ui-desktop into androidx/golden/compose/ui/ui-desktop #2819

igordmn opened this issue Mar 3, 2023 · 1 comment · Fixed by JetBrains/compose-multiplatform-core#423
Assignees
@MatkovIvan
Labels
infrastructure test

Comments

@igordmn
Copy link
Collaborator

igordmn commented Mar 3, 2023 •
edited
Loading

  1. move this folder
  2. change systemProperties["GOLDEN_PATH"] = project.rootDir.absolutePath + "/../../golden" in multiple places in androidx
  3. remove submodule compose/golden from compose-jb repo
This was referenced Mar 3, 2023
Merged
Merged
Merged
@okushnikov
Copy link
Collaborator

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MatkovIvan MatkovIvan

Labels
infrastructure test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move golden images from submodule JetBrains/compose-multiplatform-core
3 participants
@MatkovIvan @igordmn @okushnikov