Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component should not request focus immediately when scrolling list on iOS #4324

Closed
robxyy opened this issue Feb 17, 2024 · 6 comments
Closed
Assignees
Labels
bug Something isn't working ios

Comments

@robxyy
Copy link
Contributor

robxyy commented Feb 17, 2024

Describe the bug
Component should not request focus immediately when scrolling list on iOS

Affected platforms
Select one of the platforms below:

  • iOS

Versions

  • Kotlin version*: 1.9.22
  • Compose Multiplatform version*: 1.6.0-rc02

To Reproduce

Column( Modifier.fillMaxSize().verticalScroll(rememberScrollState())) {
  repeat(100) {
    Text(
      "Hello world!",
      Modifier.height(56.dp).fillMaxWidth().clickable {
      },
    )
  }
}

Expected behavior

Consistent with Android scrolling behavior

Screenshots

iOS:

Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2024-02-17.at.16.02.31.mp4

Android:

android.webm
@robxyy robxyy added bug Something isn't working submitted labels Feb 17, 2024
@dima-avdeev-jb
Copy link
Contributor

Thanks for Issue!

@robxyy
Copy link
Contributor Author

robxyy commented Feb 19, 2024

Update: Also had similar issue with TextField.

@dan15d
Copy link

dan15d commented Feb 19, 2024

Same for me with Textfield. Issue #4204

@dima-avdeev-jb
Copy link
Contributor

@mazunin-v-jb Is it duplicate?

@ASalavei ASalavei self-assigned this Mar 7, 2024
@ASalavei
Copy link
Collaborator

ASalavei commented Mar 7, 2024

It seems like behaviour with highlighting clickable text is similar for iOS and Android:
https://github.com/JetBrains/compose-multiplatform/assets/78535708/eedfbb52-c430-45cd-8c6c-9d39bea9b9ad

I would check if we can adjust initial delay a bit to match iOS timings.

However the issue #4204 is still actual. I will look at it also.

ASalavei added a commit to JetBrains/compose-multiplatform-core that referenced this issue Mar 11, 2024
## Proposed Changes
Make touch indication delay to be corresponding with iOS default delay
of UIScrollVIew.

Issue: JetBrains/compose-multiplatform#4324
@okushnikov
Copy link
Collaborator

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.

@JetBrains JetBrains locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working ios
Projects
None yet
Development

No branches or pull requests

6 participants