-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frozen composition with pager and text field #4681
Closed
alexzhirkevich opened this issue
Apr 23, 2024
· 1 comment
· Fixed by JetBrains/compose-multiplatform-core#1316
Closed
Frozen composition with pager and text field #4681
alexzhirkevich opened this issue
Apr 23, 2024
· 1 comment
· Fixed by JetBrains/compose-multiplatform-core#1316
Labels
Comments
igordmn
added
p:critical
Critical priority
submitted
reproduced
runtime
Compose runtime problem
and removed
submitted
labels
Apr 23, 2024
igordmn
added a commit
to JetBrains/compose-multiplatform-core
that referenced
this issue
Apr 24, 2024
Fixes JetBrains/compose-multiplatform#4681 The issue was because of this situation: - the parent RenderNodeLayer is drawn and cached it's `picture` - the child RenderNodeLayer isn't drawn, but `invalidate` is called the child's `invalidate` should invalidate parent layer unconditionally, but we called it only if the child was drawn (picture != null), which is incorrect. It is a regression after #1260, but it just revealed the bug, not introduced it. ## Testing - new added tests fail before, work after the fix - the issue is no longer reproducible This should be tested by QA ## Release Notes > Fixes - Multiple Platforms - _(prerelease fix)_ Fix frozen composition with pager and text field
igordmn
added a commit
to JetBrains/compose-multiplatform-core
that referenced
this issue
Apr 25, 2024
Fixes JetBrains/compose-multiplatform#4681 The issue was because of this situation: - the parent RenderNodeLayer is drawn and cached it's `picture` - the child RenderNodeLayer isn't drawn, but `invalidate` is called `invalidate` should have updated the parent layer (removing the `picture` cache), but didn't do that as we do that conditionally. Now `invalidate` invalidates the parent layer unconditionally. It is a regression after #1260, but it just revealed the bug, didn't introduce it. ## Testing - new added tests fail before, work after the fix - the issue is no longer reproducible This should be tested by QA ## Release Notes > Fixes - Multiple Platforms - _(prerelease fix)_ Fix frozen composition with pager and text field
Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Describe the bug
Weird frozen composition bug with
Scaffold
,HorizontalPager
and text field (basic or material).Input doesn't work, content inside pager is unresponsive until external recomposition occurred.
Happens only when
pagerState.targetPage
is read from some drawing context inside topBar or bottomBarWorks fine in
1.6.10-dev1575
. Doesn't work starting from1.6.10-dev1578
Possibly related: JetBrains/compose-multiplatform-core#1260
Affected platforms
Skiko backed
Versions
1.6.10-dev1578
To Reproduce
The text was updated successfully, but these errors were encountered: