Request for opting out of generating skiko wasm / js resources in latest compose plugin (1.6.10-rc03) #4823
Labels
Comments
bitspittle
changed the title
eymar
added a commit
that referenced
this issue
May 17, 2024
…ed (#4824) Fixes: #4823 In #4796 we intentionally started to configure the web app for all k/js and k/wasm targets. The configuration involves adding a dependency on skiko-wasm runtime and unpacking it. Some projects don't need skiko-wasm-runtime (like those based on compose.html or just compose.runtime). **Solution:** We check if there is a dependency on org.jetbrains.compose.ui libraries (including transitive dependencies). If we find it, then we enable skikoUnpack task. Otherwise it's disabled. ## Testing - Build the gradle plugin locally (with this change) - Used it in our html landing example: https://github.com/JetBrains/compose-multiplatform/blob/master/examples/html/landing - Run `./gradlew jsBrowserDistribution`, check `.../compose-multiplatform/examples/html/landing/build/dist/js/productionExecutable` and see NO skiko.* files added there - Then add `implementation(compose.foundation)` dependency in build.gradle.jts and run `./gradlew clean jsBrowserDistribution` again - the build/dist contains skiko.* now
eymar
added a commit
that referenced
this issue
May 17, 2024
…ed (#4824) Fixes: #4823 In #4796 we intentionally started to configure the web app for all k/js and k/wasm targets. The configuration involves adding a dependency on skiko-wasm runtime and unpacking it. Some projects don't need skiko-wasm-runtime (like those based on compose.html or just compose.runtime). **Solution:** We check if there is a dependency on org.jetbrains.compose.ui libraries (including transitive dependencies). If we find it, then we enable skikoUnpack task. Otherwise it's disabled. ## Testing - Build the gradle plugin locally (with this change) - Used it in our html landing example: https://github.com/JetBrains/compose-multiplatform/blob/master/examples/html/landing - Run `./gradlew jsBrowserDistribution`, check `.../compose-multiplatform/examples/html/landing/build/dist/js/productionExecutable` and see NO skiko.* files added there - Then add `implementation(compose.foundation)` dependency in build.gradle.jts and run `./gradlew clean jsBrowserDistribution` again - the build/dist contains skiko.* now (cherry picked from commit 30164c5)
|
Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I'm using Compose HTML, and it seems like the most recent version of Compose started generating skiko wasm and js as part of the build process. This seems to be because "Compose for Web" is now enabled by default.
I have my own resource processing task, and now I'm getting:
Of course, I can hook my task up to the skiko task, but if I don't need the skiko resources, I would much rather skip over generating them in the first place.
The text was updated successfully, but these errors were encountered: