-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to pack jars as uber JAR, support Proguard for uber JAR #4136
Conversation
@badmannersteam could you add integration tests for that? |
@terrakok probably yes, but what configuration combinations they should check? |
I would expect a multi-module project + proguard as uberjar and a regular multi-module project |
...rc/main/kotlin/org/jetbrains/compose/desktop/application/internal/configureJvmApplication.kt
Outdated
Show resolved
Hide resolved
Added some tests. |
@terrakok seems like that all for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'll check the tests today and also want to fix the issue on Windows, that was mentioned above (by flattering into the intermediate jar instead of directory). |
@badmannersteam could you check failed tests and rebase the branch on top of the master? |
…e' tasks now depend on Proguard.
80bcfc8
to
7fe647f
Compare
@terrakok all done. |
@igordmn, look at this pls :) |
Most probably yes, it will be in the next release (1.6.10). I plan to review it soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
LGTM.
Few things:
- I changed the title/description by our new PR format
- I moved README to support/1.6.10, which will be merged to
master
on the release date
Proposed changes
Testing
A new auto test
Manual:
joinOutputJars
:false
(by default) should generate multiple jars (except forpackage*UberJarForCurrentOS
)true
should generate a single jar in a result distribution3. Test debug tasks:
The jars should be reduced in size (because Proguard is enabled in the release mode)
This should be test by QA.
Issues fixed
Fixes #4129