Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resource accessors compilation when there are huge number of resource files. #4294

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Fix resource accessors compilation when there are huge number of resource files. #4294

merged 1 commit into from
Feb 14, 2024

Conversation

terrakok
Copy link
Member

@terrakok terrakok commented Feb 13, 2024 •
edited by igordmn
Loading

Instead of object properties there are being generated extension properties in different files.

fixes #4285

Breaking changes

since 1.6.0-beta01

  • When the resource library is used, resources should be imported explicitly. Replace this:
import <modulePackage>.generated.resources.Res

by this:

import <modulePackage>.generated.resources.Res
import <modulePackage>.generated.resources.*

@terrakok
Fix resource accessors compilation when there are huge number of reso…
7ef0725 
…urce files.

Instead of object properties there are being generated extension properties in different files.
@terrakok terrakok requested a review from pjBooms February 13, 2024 21:35
igordmn
igordmn approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@igordmn igordmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the general idea after online discussion. The code still need to be reviewed

@terrakok terrakok merged commit a73f8fa into master Feb 14, 2024
6 checks passed
@terrakok terrakok deleted the k.tskh/huge-num-res branch February 14, 2024 12:06
igordmn pushed a commit that referenced this pull request Feb 14, 2024
@terrakok @igordmn
Fix resource accessors compilation when there are huge number of reso…
cc0e184 
…urce files. (#4294)

Instead of object properties there are being generated extension
properties in different files.

fixes #4285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igordmn igordmn igordmn approved these changes

@pjBooms pjBooms pjBooms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MethodTooLargeException with huge icon pack
3 participants
@terrakok @pjBooms @igordmn