[resources] Init resource accessors lazily and in external function to avoid MethodTooLargeException #4404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o avoid MethodTooLargeException More info: #4194
pjBooms
approved these changes
Mar 4, 2024
terrakok
added
the
changelog1.6.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated static acessors to resources look like kotlin objects with static properties.
A count of properties is limited by 500 to avoid a MethodTooLargeException when a generated init function of the object is to large. But this reproduces when one resource has a lot of variant in different locales, and it may increase the init function.
To handle it I extracted property initializers outside the init function.
As additional optimization I made static properties lazy to init them on demand.
fixes #4194