VIM-1756: Fix escape key when moving from insert mode to select mode #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaunpatterson
force-pushed
the
VIM-1756-FixEscape
branch
from
4c8aa2a to
8311711
Compare
|
Hi! Sorry for such a big delay. Actually, I'm not sure that the current behaviour of IdeaVim is incorrect. I've checked this in vim and neovim and it looks like they both exit only select mode in this case and leave the editor in insert mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for VIM-1756. Original PR: #251
When moving from Insert mode to Select mode, the escape key would only exit select mode.
Steps to reproduce:
With ideavimrc settings
set selectmode+=key
set keymodel^=startsel
From anywhere in an editor, enter insert mode, select+arrow left, escape. Your cursor will still be in insert mode. This fix escapes Insert mode as well.
Not sure if this is the BEST fix. Open to suggestions.