Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes http://youtrack.jetbrains.com/issue/VIM-287 #32

Closed
wants to merge 1 commit into from

Conversation

breandan
Copy link

ChangeGroup looks like it could be refactored to use com.intellij.openapi.editor.actions as there are a few other surprises like this one. EditorActionUtil.moveCaretToLineEnd(...) seems to put us exactly where we need to be after the fold, and takes into account soft-wraps etc. - ChangeGroup.insertNewLineBelow(...) and ChangeGroup.insertNewLineAbove(...) will now behave as expected.

@jbyler
Copy link

jbyler commented Oct 23, 2014

See also PR#43

@rasendubi
Copy link
Contributor

Unable to compile, should import com.intellij.openapi.editor.actions.EditorActionUtil; first.
Failed to pass both tests from #43.

@breandan breandan closed this Aug 6, 2015
@vlasovskikh
Copy link
Contributor

@breandan Did your fix solve this problem for you? I don't remember if I tried / tested it. PR #43 definitely doesn't work in many cases. Why have you closed your PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants