Fixed upload structure. Source and test folder handling now works #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test folders are skipped unless they are being uploaded explicitly.
|
Unfortunately, does not work normally with a project with several source roots, ex layout-b |
|
Okay, I can look into that, look at the included test layouts and see if I can get it working changing some code. EDIT: I see what is wrong with files directly in the project being uploaded when there are marked source folders now. I can adjust the logic, I have only fixed the previous bug with uploads being weird overall. |
|
Please try the latest commit. |
|
I am working now on adding some tests for this functionality. When it's done, I'll have a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made modifications to the uploading logic. Source folders are now treated properly as before, test folders are skipped unless they are explicitly selected for the upload, only their contents get uploaded though, when they are selected - this might need to be fine-tuned according to your vision.
I have tested this and it works for me, I haven't been able to find a bug in this.