Suggested text adjustments and typo fixes #345
+19
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elmot
reviewed
Nov 23, 2024
src/main/kotlin/com/jetbrains/micropython/nova/ConnectAction.kt
Outdated
Show resolved
Hide resolved
elmot
reviewed
Nov 23, 2024
| @@ -100,7 +100,7 @@ class MicroPythonSettingsPanel(private val module: Module, disposable: Disposabl | |||
| ) | |||
| .validationInfo { comboBox -> | |||
| val portName = comboBox.selectedItem.asSafely<String>() | |||
| if (portName.isNullOrBlank()) ValidationInfo("No port name provided").withOKEnabled() | |||
| if (portName.isNullOrBlank()) ValidationInfo("No port name was provided").withOKEnabled() | |||
There was a problem hiding this comment.
is provided sounds better IMO
There was a problem hiding this comment.
I think that it has to stay "was provided" as the action happened in the past, the user first had to provide a port name and if he did not, then it can be said that "No port name was provided".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After going through the full code base, I feel like some text that the plugin displays to the user could be adjusted slightly. Here are my ideas: