Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass structure warnings to verification reports #1080

Merged

Conversation

novotnyr
Copy link
Collaborator

@novotnyr novotnyr commented Apr 3, 2024

Pass structure warnings and structure unacceptable warnings to the verification reports.

This will show warnings in all outputs (HTML, Markdown, stdout).

For example:

Plugin com.github.novotnyr.plugin-service-preloading:1.0-SNAPSHOT against IE-203.7717.75: Compatible. 2 plugin configuration defects
Plugin structure warnings (2): 
    Invalid plugin descriptor 'plugin.xml'. The change-notes parameter contains the default value 'Add change notes here' or 'most HTML tags may be used'.
    Service preloading is deprecated in the <com.intellij.applicationService> element. Remove the 'preload' attribute and migrate to listeners, see https://plugins.jetbrains.com/docs/intellij/plugin-listeners.html.
Dynamic Plugin Eligibility:
    Plugin can probably be enabled or disabled without IDE restart

See MP-6458 Structure Warnings are not reported in CLI outputs

  • Make default IntelliJ plugin implementation carry structural problems
  • Improve presentation of plugin defects in the HTML output
  • Plugin Detail Provider will resolve available plugin problems from plugin implementation
  • Remove unused methods from Plugin Detail Provider which handle plugin problems in a manual way

@YannCebron
Copy link
Member

Are there no tests that need alignment? Can we create them?

@novotnyr
Copy link
Collaborator Author

novotnyr commented Apr 4, 2024

Are there no tests that need alignment? Can we create them?

Test were created.

@novotnyr novotnyr merged commit b51274a into master Apr 9, 2024
4 checks passed
@novotnyr novotnyr deleted the mp-6458-pass-structure-warnings-to-verification-reports branch April 9, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants