Custom XInclude attributes and resolution mechanisms #1097
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
includeIf
andincludeUnless
attributes in the XInclude elements. Properties are resolved against System properties. This feature requirescom.jetbrains.plugin.structure.intellij.xinclude.isResolvingConditionalIncludes
system property to be set totrue
. By default, aninclude
element with either of these attributes will be ignored and not processed for inclusion.This feature is implemented by the Kotlin plugin and should not be used in other plugins.
Resolve issues with XMLs referencing each other and being set in
META-INF
and resource roots.This is an issue in Kotlin plugin. Imagine the following ZIP file contents
The
plugin.xml
conditionally includeskotlin.plugin.k1.xml
(viahref="kotlin.plugin.k1.xml"
).Additionally,
kotlin.plugin.k1.xml
includeskotlin-core.xml
, again viahref="kotlin-core.xml"
.This is not in line with XInclude specification. However, the support for such scenarios is implemented.