Fix NPE on delegate calls in OverrideOnly checks #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is a super call and no delegate is set, or that delegate is either `this` or `super`, do not apply this filter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DelegateCallOnOverrideOnlyUsageFilterthat checks for delegate calls on methods with@OverrideOnlymight fail when a delegate issuper.Filter out such method calls immediately, as
SuperclassCallOnOverrideOnlyUsageFiltermight be applied only in the later stages of API usage filtering.See MP-6724 Plugin Verifier: NPE on delegate calls in OverrideOnly Checks